Bug 34971

Summary: check-webkit-style should report the number of files checked
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch v1 none

Shinichiro Hamaji
Reported 2010-02-16 03:01:04 PST
Currently, check-webkit-style reports Total errors found: 0 when the check succeeded. This message isn't good because this message also happens when no files are checked. For example, suppose there's a git commit and no unstaged changes. If you run check-webkit-style without options, no files will be checked. If you want to check the committed change, you need to specify --git-commit=HEAD . Reporting the number of files checked by the style checker would help to avoid this kind of mistakes. With the patch I'll post, the style checker will report Total errors found: 0 in 0 files We may be able to report more info, but this would be good as the start point. I'm not sure if this change breaks WebKit buildbot (I guess it's OK because it checks the exit status code?). Adam and Eric, could you check it?
Attachments
Patch v1 (3.67 KB, patch)
2010-02-16 03:01 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-02-16 03:01:59 PST
Created attachment 48799 [details] Patch v1
Eric Seidel (no email)
Comment 2 2010-02-17 16:38:09 PST
Comment on attachment 48799 [details] Patch v1 OK.
Shinichiro Hamaji
Comment 3 2010-02-17 18:00:24 PST
Comment on attachment 48799 [details] Patch v1 Clearing flags on attachment: 48799 Committed r54917: <http://trac.webkit.org/changeset/54917>
Shinichiro Hamaji
Comment 4 2010-02-17 18:00:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.