Bug 34954

Summary:

PlatformContextSkia limits SVG stroke width

Product:

WebKit

Reporter:

Bryan Yeung <bryeung>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Attachments:

Description	Flags
remove bounds and add a layout test for the regression	zimmermann: review+, commit-queue: commit-queue-
same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard	none

Bryan Yeung

Reported 2010-02-15 12:25:14 PST

WebCore/platform/graphics/skia/PlatformContextSkia.cpp imposes a very low limit (512) on stroke width. This causes some SVG images to render incorrectly.

Attachments
remove bounds and add a layout test for the regression (21.35 KB, patch) 2010-02-15 12:35 PST, Bryan Yeung	zimmermann: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard (21.41 KB, patch) 2010-02-16 13:18 PST, Bryan Yeung	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Bryan Yeung

Comment 1 2010-02-15 12:35:47 PST

Created attachment 48768 [details] remove bounds and add a layout test for the regression

Nikolas Zimmermann

Comment 2 2010-02-15 17:37:40 PST

Comment on attachment 48768 [details] remove bounds and add a layout test for the regression r=me, looks fine.

WebKit Commit Bot

Comment 3 2010-02-15 18:49:50 PST

Comment on attachment 48768 [details] remove bounds and add a layout test for the regression Rejecting patch 48768 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12164 test cases. svg/custom/stroke-width-large.svg -> failed Exiting early after 1 failures. 9784 tests run. 211.53s total testing time 9783 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/268930

Bryan Yeung

Comment 4 2010-02-16 13:18:36 PST

Created attachment 48819 [details] same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard

Nikolas Zimmermann

Comment 5 2010-02-16 16:23:09 PST

Comment on attachment 48819 [details] same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard Let's retry :-)

WebKit Commit Bot

Comment 6 2010-02-16 19:05:49 PST

Comment on attachment 48819 [details] same code change and test, but with expected values for the test generated on Leopard instead of Snow Leopard Clearing flags on attachment: 48819 Committed r54859: <http://trac.webkit.org/changeset/54859>

WebKit Commit Bot

Comment 7 2010-02-16 19:05:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.