Bug 34945

Summary:

Improve API for form validation message strings

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, dglazkov, dimich, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none
Proposed patch (rev.3)	none
Patch	none
Patch 5	none

Kent Tamura

Reported 2010-02-15 08:23:55 PST

Improve form validation messages.

Attachments
Proposed patch (44.96 KB, patch) 2010-02-15 08:30 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Proposed patch (50.14 KB, patch) 2010-02-15 08:37 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Proposed patch (rev.3) (50.14 KB, patch) 2010-03-08 23:09 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Patch (28.95 KB, patch) 2010-11-10 23:28 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Patch 5 (30.95 KB, patch) 2010-11-14 20:53 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2010-02-15 08:30:25 PST

Created attachment 48754 [details] Proposed patch

Kent Tamura

Comment 2 2010-02-15 08:37:08 PST

Created attachment 48756 [details] Proposed patch

Kent Tamura

Comment 3 2010-03-08 23:09:50 PST

Created attachment 50278 [details] Proposed patch (rev.3) Upload the same patch again to kick EWS.

Kent Tamura

Comment 4 2010-03-08 23:39:36 PST

(In reply to comment #3) > Created an attachment (id=50278) [details] > Proposed patch (rev.3) > > Upload the same patch again to kick EWS. Oh, I understand. svn-apply doesn't support Git binary diff.

Eric Seidel (no email)

Comment 5 2010-03-25 01:35:04 PDT

It does not support delta binary diffs, only literal binary diffs. :)

Adam Barth

Comment 6 2010-06-20 08:46:47 PDT

Comment on attachment 50278 [details] Proposed patch (rev.3) This patch has been up for review for too long. Who's the right person to review this patch? Why has it stalled out? I don't know whether the new messages are better or worse than the old messages. Is there a spec for this stuff? Something has broken down here. LayoutTests/fast/forms/script-tests/validationMessage.js:16 + "'The value does not match to a character restriction for this field.'"); Where do these messages come from? Are they speced somewhere?

Kent Tamura

Comment 7 2010-11-10 23:15:29 PST

I have changed my mind. I won't change the existing form validation messages, and just add some additional parameters to validationMessage*() functions in order that a port can improve the messages.

Kent Tamura

Comment 8 2010-11-10 23:28:38 PST

Created attachment 73583 [details] Patch

Dimitri Glazkov (Google)

Comment 9 2010-11-12 12:35:09 PST

Comment on attachment 73583 [details] Patch ok.

Kent Tamura

Comment 10 2010-11-14 20:53:15 PST

Created attachment 73873 [details] Patch 5

Kent Tamura

Comment 11 2010-11-14 20:54:48 PST

(In reply to comment #9) > (From update of attachment 73583 [details]) > ok. Thank you for r+. But I have updated the patch. I added a dedicated function for <input type=email multiple>. It should show a different message than <input type=email>.

Dimitri Glazkov (Google)

Comment 12 2010-11-14 21:06:25 PST

Comment on attachment 73873 [details] Patch 5 ok.

Kent Tamura

Comment 13 2010-11-14 21:40:15 PST

Comment on attachment 73873 [details] Patch 5 Clearing flags on attachment: 73873 Committed r71996: <http://trac.webkit.org/changeset/71996>

Kent Tamura

Comment 14 2010-11-14 21:40:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.