Summary: | [GTK] Fails to build on GNU/Hurd because of PATH_MAX usage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emilio Pozuelo Monfort <pochu27> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
Emilio Pozuelo Monfort
2010-02-13 07:06:18 PST
Created attachment 48703 [details]
Avoid using PATH_MAX for portability reasons
The patch is against 1.1.20 and builds fine, so since the patch is for the test suite, the tests should be fine :)
Comment on attachment 48703 [details]
Avoid using PATH_MAX for portability reasons
Patch looks sane, can you add a ChangeLog entry to WebKit/gtk/ChangeLog, and repost, please? =)
Created attachment 48730 [details]
Avoid using PATH_MAX for portability reasons
Now with a ChangeLog entry. Patch against current git.
I haven't built the tests in git, should I? If so, what's the best way to do it?
Comment on attachment 48730 [details]
Avoid using PATH_MAX for portability reasons
Setting the review flag, since Emilio forgot it.
Comment on attachment 48730 [details]
Avoid using PATH_MAX for portability reasons
Thanks!
Comment on attachment 48730 [details] Avoid using PATH_MAX for portability reasons Clearing flags on attachment: 48730 Committed r54779: <http://trac.webkit.org/changeset/54779> All reviewed patches have been landed. Closing bug. |