Bug 34897

Summary: [Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch fishd: review+

Jeremy Orlow
Reported 2010-02-12 09:46:07 PST
[Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
Attachments
Patch (3.83 KB, patch)
2010-02-12 10:00 PST, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (4.55 KB, patch)
2010-02-12 11:19 PST, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (4.55 KB, patch)
2010-02-12 11:40 PST, Jeremy Orlow 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-02-12 10:00:19 PST
Created attachment 48650 [details] Patch
Jeremy Orlow
Comment 2 2010-02-12 10:01:43 PST
Other half of the review you were looking at, Darin.
Darin Fisher (:fishd, Google)
Comment 3 2010-02-12 10:36:27 PST
Comment on attachment 48650 [details] Patch R=me, but it seems like it would be nice to extend the DOMStorageSetItemResult enum to the WebKit API. Or, at least it would also be nice to rename quotaException to blockedByQuota.
Jeremy Orlow
Comment 4 2010-02-12 10:45:22 PST
(In reply to comment #3) > (From update of attachment 48650 [details]) > R=me, but it seems like it would be nice to extend the DOMStorageSetItemResult > enum to the WebKit API. Or, at least it would also be nice to rename > quotaException to blockedByQuota. How would we do that? Move it entirely into the WebKit layer and have Chromium refer to that enum or have 2 of them and translate?
Darin Fisher (:fishd, Google)
Comment 5 2010-02-12 10:48:51 PST
It is fine to use WebKit API defined enums in Chromium code. That might be best if you want to do that.
Jeremy Orlow
Comment 6 2010-02-12 11:19:29 PST
Created attachment 48652 [details] Patch
Jeremy Orlow
Comment 7 2010-02-12 11:40:28 PST
Created attachment 48654 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.