Bug 34877

Summary:

Rename underscored identifiers in CSSParser.cpp

Product:

WebKit

Reporter:

Yuzo Fujishima <yuzo>

Component:

CSS

Assignee:

Yuzo Fujishima <yuzo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hamaji, hayato, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Rename underscored identifiers in WebCore/css/CSSParser.cpp.	hamaji: review+
Rename underscored identifiers in WebCore/css/CSSParser.cpp.	none
Rename underscored identifiers in WebCore/css/CSSParser.cpp.	none
Rename underscored identifiers in WebCore/css/CSSParser.cpp.	hamaji: review+

Yuzo Fujishima

Reported 2010-02-11 21:46:20 PST

WebCore/css/CSSParser.cpp contains underscored identifiers. They should be renamed. WebCore/css/CSSParser.cpp:574: valid_primitive is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/css/CSSParser.cpp:1079: is_valid is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Note: yy_* are handled by https://bugs.webkit.org/show_bug.cgi?id=34067 and https://bugs.webkit.org/show_bug.cgi?id=34787.

Attachments
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (35.49 KB, patch) 2010-02-11 21:56 PST, Yuzo Fujishima	hamaji: review+	Details Formatted Diff Diff
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (36.35 KB, patch) 2010-02-11 21:57 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (36.08 KB, patch) 2010-02-11 22:04 PST, Yuzo Fujishima	no flags	Details Formatted Diff Diff
Rename underscored identifiers in WebCore/css/CSSParser.cpp. (40.91 KB, patch) 2010-02-11 22:12 PST, Yuzo Fujishima	hamaji: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yuzo Fujishima

Comment 1 2010-02-11 21:56:29 PST

Created attachment 48622 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.

Yuzo Fujishima

Comment 2 2010-02-11 21:57:50 PST

Created attachment 48623 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.

Shinichiro Hamaji

Comment 3 2010-02-11 21:58:27 PST

Comment on attachment 48622 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp. Looks great!

WebKit Review Bot

Comment 4 2010-02-11 22:00:42 PST

Attachment 48623 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/css/CSSParser.cpp:776: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:971: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:986: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:994: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1010: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1019: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1034: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1053: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1246: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1270: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1280: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1286: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1461: Missing spaces around | [whitespace/operators] [3] Total errors found: 13 If any of these errors are false positives, please file a bug against check-webkit-style.

Shinichiro Hamaji

Comment 5 2010-02-11 22:01:45 PST

Comment on attachment 48623 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp. > + WebCore/css/CSSParser.cpp:574: valid_primitive is incorrectly named. Don't use > + underscores in your identifier names. [readability/naming] [4] > + WebCore/css/CSSParser.cpp:1079: is_valid is incorrectly named. Don't use > + underscores in your identifier names. [readability/naming] [4] I'm not sure if we need these 4 lines in ChangeLog. > + No new tests are required. It would be better to say the reason why we don't need new tests.

Yuzo Fujishima

Comment 6 2010-02-11 22:04:39 PST

Created attachment 48624 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.

WebKit Review Bot

Comment 7 2010-02-11 22:06:13 PST

Attachment 48624 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/css/CSSParser.cpp:776: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:971: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:986: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:994: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1010: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1019: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1034: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1053: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1246: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1270: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1280: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1286: Missing spaces around | [whitespace/operators] [3] WebCore/css/CSSParser.cpp:1461: Missing spaces around | [whitespace/operators] [3] Total errors found: 13 If any of these errors are false positives, please file a bug against check-webkit-style.

Yuzo Fujishima

Comment 8 2010-02-11 22:12:33 PST

Created attachment 48626 [details] Rename underscored identifiers in WebCore/css/CSSParser.cpp.

Yuzo Fujishima

Comment 9 2010-02-11 22:18:30 PST

Fixed the Change log and new style issues that surfaced after fixing underscored names. Can you take another look?

Yuzo Fujishima

Comment 10 2010-02-11 22:42:32 PST

Committed r54703: <http://trac.webkit.org/changeset/54703>

Note You need to log in before you can comment on or make changes to this bug.