Bug 34848

Summary:

Web Inspector: Move JSC-specific Profile and ProfileNode wrappers to bindings/js

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none
updated patch with a small fix	none
instead of replacing, just move those wrappers	pfeldman: review-
fixed style issues in the last patch	pfeldman: review+
committed revision -- no changes to JSBindingsAllInOne.cpp	none

Mikhail Naganov

Reported 2010-02-11 08:44:22 PST

Currently to make profiles accessible from Inspector and Console hand-written wrappers are used (WebCore/inspector/JavaScriptProfile*). I think it makes more sense to use generated bindings instead.

Attachments
Proposed patch (55.54 KB, patch) 2010-02-11 08:48 PST, Mikhail Naganov	no flags	Details Formatted Diff Diff
updated patch with a small fix (55.52 KB, patch) 2010-02-12 04:35 PST, Mikhail Naganov	no flags	Details Formatted Diff Diff
instead of replacing, just move those wrappers (58.14 KB, patch) 2010-02-12 07:17 PST, Mikhail Naganov	pfeldman: review-	Details Formatted Diff Diff
fixed style issues in the last patch (57.41 KB, patch) 2010-02-15 03:31 PST, Mikhail Naganov	pfeldman: review+	Details Formatted Diff Diff
committed revision -- no changes to JSBindingsAllInOne.cpp (56.85 KB, patch) 2010-02-16 05:20 PST, Mikhail Naganov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2010-02-11 08:48:07 PST

Created attachment 48569 [details] Proposed patch

Mikhail Naganov

Comment 2 2010-02-12 04:35:49 PST

Created attachment 48636 [details] updated patch with a small fix

Mikhail Naganov

Comment 3 2010-02-12 07:17:57 PST

Created attachment 48644 [details] instead of replacing, just move those wrappers

WebKit Review Bot

Comment 4 2010-02-12 07:21:42 PST

Attachment 48644 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Skipping input 'WebCore/inspector/JavaScriptProfileNode.h': Can't open for reading WebCore/bindings/js/JavaScriptProfileNode.h:32: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/JavaScriptProfileNode.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/bindings/js/JavaScriptProfile.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Skipping input 'WebCore/inspector/JavaScriptProfileNode.cpp': Can't open for reading Skipping input 'WebCore/inspector/JavaScriptProfile.h': Can't open for reading Skipping input 'WebCore/inspector/JavaScriptProfile.cpp': Can't open for reading WebCore/bindings/js/JavaScriptProfile.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/bindings/js/JavaScriptProfileNode.cpp:33: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/JavaScriptProfileNode.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 If any of these errors are false positives, please file a bug against check-webkit-style.

Pavel Feldman

Comment 5 2010-02-12 08:26:03 PST

Comment on attachment 48644 [details] instead of replacing, just move those wrappers I think you should merge JavaScriptProfile into ScriptProfile. JavaScriptNode also should be simply ScriptNode, both encapsulating JSC specifics. There is no more need in typedefs.

Mikhail Naganov

Comment 6 2010-02-15 03:31:04 PST

Created attachment 48745 [details] fixed style issues in the last patch

Pavel Feldman

Comment 7 2010-02-15 08:21:50 PST

Comment on attachment 48745 [details] fixed style issues in the last patch Please make sure you land it as svn move.

Mikhail Naganov

Comment 8 2010-02-16 05:20:34 PST

Created attachment 48808 [details] committed revision -- no changes to JSBindingsAllInOne.cpp

Mikhail Naganov

Comment 9 2010-02-16 05:21:50 PST

Manually committed r54820: http://trac.webkit.org/changeset/54820

Note You need to log in before you can comment on or make changes to this bug.