Bug 34840

Summary:

[Android] cmath using declarations in MathExtras.h cause build errors on Android

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, darin, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
Patch	darin: review+

Description Steve Block 2010-02-11 07:26:46 PST

cmath using declarations in MathExtras.h cause build errors on Android
Android does not provide these math functions

This was introduced in http://trac.webkit.org/changeset/54388

Comment 1 Steve Block 2010-02-11 07:32:26 PST

Created attachment 48561 [details]
Patch

Comment 2 Darin Adler 2010-02-11 07:51:08 PST

Comment on attachment 48561 [details]
Patch

I don't see why you are specifying COMPILER(GCC) there, but it seems OK.

Comment 3 Steve Block 2010-02-11 08:04:35 PST

Landed manually without GCC guard as http://trac.webkit.org/changeset/54655

Closing bug as resolved fixed