Bug 34836

Summary:

[Android] V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, dglazkov, japhet, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
Patch	none
Patch	dglazkov: review+, steveblock: commit-queue-

Steve Block

Reported 2010-02-11 04:32:02 PST

V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h This is so that these files can use toV8() with type Node* in V8Collection.h This was introduced in http://trac.webkit.org/changeset/54150 It seems that for Chromium, this include is picked up through an include chain which is guarded by a feature enable guard not used on Android.

Attachments
Patch (1.35 KB, patch) 2010-02-11 04:36 PST, Steve Block	no flags	Details Formatted Diff Diff
Patch (1.43 KB, patch) 2010-02-11 09:17 PST, Steve Block	dglazkov: review+ steveblock: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-02-11 04:36:15 PST

Created attachment 48557 [details] Patch

Dimitri Glazkov (Google)

Comment 2 2010-02-11 08:40:33 PST

Comment on attachment 48557 [details] Patch Per IM discussion, the right approach here is to make sure V8Node is correctly included whenever setCollectionIndexedGetter template is used, because it in turn uses toV8.

Steve Block

Comment 3 2010-02-11 09:17:13 PST

Created attachment 48570 [details] Patch

Dimitri Glazkov (Google)

Comment 4 2010-02-11 10:21:05 PST

Comment on attachment 48570 [details] Patch sounds good.

Steve Block

Comment 5 2010-02-11 10:26:39 PST

Comment on attachment 48570 [details] Patch Will land manually as build is currently red

Steve Block

Comment 6 2010-02-11 10:28:35 PST

Landed manually as http://trac.webkit.org/changeset/54658 Closing bug as resolved fixed

Note You need to log in before you can comment on or make changes to this bug.