Bug 34834

Summary:

check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch for this issue	darin: review+, mrobinson: commit-queue-

Martin Robinson

Reported 2010-02-11 01:28:53 PST

Using 0 in place of NULL for these functions generates a compiler warning. check-webkit-style should make a similar check to the one done for g_object_get and g_object_set.

Attachments
Patch for this issue (3.16 KB, patch) 2010-02-13 13:21 PST, Martin Robinson	darin: review+ mrobinson: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-02-13 13:21:26 PST

Created attachment 48711 [details] Patch for this issue I've attached a patch for this issue.

Martin Robinson

Comment 2 2010-02-15 22:17:53 PST

Committed r54808: <http://trac.webkit.org/changeset/54808>

Note You need to log in before you can comment on or make changes to this bug.