Bug 34830

Summary:

Update webkit-patch modules to use User.prompt instead of raw_input and add optional support for repeated prompting for user input

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch with unit tests	none
Patch with unit tests	none

Daniel Bates

Reported 2010-02-10 23:13:47 PST

We should substitute the method User.prompt for raw_input throughout the various webkit-patch modules as well as add optional support for repeated prompting for user input.

Attachments
Patch with unit tests (7.76 KB, patch) 2010-02-11 08:29 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch with unit tests (8.32 KB, patch) 2010-02-11 08:41 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2010-02-11 08:29:46 PST

Created attachment 48565 [details] Patch with unit tests

Daniel Bates

Comment 2 2010-02-11 08:41:38 PST

Created attachment 48567 [details] Patch with unit tests Updated prototype of method MockUser.prompt to match User.prompt. Fixed spacing/new line issue at end of file in user_unittest.py. Updated change log.

Adam Barth

Comment 3 2010-02-11 13:58:39 PST

Comment on attachment 48567 [details] Patch with unit tests Very nice dependency injection.

Daniel Bates

Comment 4 2010-02-11 18:00:30 PST

Comment on attachment 48567 [details] Patch with unit tests Clearing flags on attachment: 48567 Committed r54693: <http://trac.webkit.org/changeset/54693>

Daniel Bates

Comment 5 2010-02-11 18:00:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.