Bug 34830

Summary:

Update webkit-patch modules to use User.prompt instead of raw_input and add optional support for repeated prompting for user input

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch with unit tests	none
Patch with unit tests	none

Description Daniel Bates 2010-02-10 23:13:47 PST

We should substitute the method User.prompt for raw_input throughout the various webkit-patch modules as well as add optional support for repeated prompting for user input.

Comment 1 Daniel Bates 2010-02-11 08:29:46 PST

Created attachment 48565 [details]
Patch with unit tests

Comment 2 Daniel Bates 2010-02-11 08:41:38 PST

Created attachment 48567 [details]
Patch with unit tests

Updated prototype of method MockUser.prompt to match User.prompt. Fixed spacing/new line issue at end of file in user_unittest.py. Updated change log.

Comment 3 Adam Barth 2010-02-11 13:58:39 PST

Comment on attachment 48567 [details]
Patch with unit tests

Very nice dependency injection.

Comment 4 Daniel Bates 2010-02-11 18:00:30 PST

Comment on attachment 48567 [details]
Patch with unit tests

Clearing flags on attachment: 48567

Committed r54693: <http://trac.webkit.org/changeset/54693>

Comment 5 Daniel Bates 2010-02-11 18:00:37 PST

All reviewed patches have been landed.  Closing bug.