Summary: | Microsoft Visual Studio 2008 (9.0) compatibility patch | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eugene Lavrenov <evgenilv> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | aroben, barraclough, eric, laszlo.gombos, tonyg | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Eugene Lavrenov
2010-02-10 20:45:21 PST
Created attachment 48545 [details]
Patch
Comment on attachment 48545 [details]
Patch
You should check the "patch" checkbox and set the "review" flag to "?" if you want a patch to be reviewed.
Comment on attachment 48545 [details] Patch Also, please attach your patch as a unified diff. See <http://webkit.org/coding/contributing.html> for instructions. *** This bug has been marked as a duplicate of bug 34804 *** Since the compiler warnings are already covered by bug 34804, let's make this bug only be about build-webkit not working with VS2008 and VS2010. Please split up your work to fix these issues into two separate patches. Thanks! Comment on attachment 48545 [details] Patch As previously requested, please upload a unified diff instead of a zip file, as described here: <http://webkit.org/coding/contributing.html>. Also, please split this patch up into two pieces: one that fixes build-webkit (which should be attached to this bug), and one that fixes the compiler warnings (which should be attached to bug 34804). (In reply to comment #3) > (From update of attachment 48545 [details]) > You should check the "patch" checkbox and set the "review" flag to "?" if you > want a patch to be reviewed. Done (In reply to comment #4) > (From update of attachment 48545 [details]) > Also, please attach your patch as a unified diff. See > <http://webkit.org/coding/contributing.html> for instructions. I am aware about the instructions, however, none of these scripts: * run-webkit-tests * prepare-ChangeLog * svn-create-patch works in my environment, regardless that I successfully checked out the code using svn command as described here: http://webkit.org/building/checkout.html You probably noticed that my e-mail account is on "yahoo.ca". It means that I do not work for Apple, Google, Nokia, RIM or other corporate contributors of WebKit project and of course I am NOT PAID for this work unlike most of you. I cannot afford wasting too much time to fix the environment to generate a patch in accordance to the instruction. The patch has all affected files in right folders. If you copy a WebKit folder from a patch to your project, it will substitute original files and make your project compliable in VS2008 and reduce number of compiler errors for VS2010. (In reply to comment #5) > Since the compiler warnings are already covered by bug 34804, let's make this > bug only be about build-webkit not working with VS2008 and VS2010. Please split > up your work to fix these issues into two separate patches. Thanks! If it is possible I would prefer to leave the patch as is because: 1. There is no reason to flood your system with multiple attachments, which will be the same 2. The patch is very simple. 3. It affects two projects JavaScriptCore and WebKitTools, but it is a turnkey solution for compiling and building WebKit in VS2008. Comment on attachment 48545 [details]
Patch
This is not a patch file, it's a zip.
For better or worse, with 30-50 patches coming in to webkit.org every day, and there only being 30 or so active reviewers (not all of which are paid, as you claim), we just can't handle exceptions to the process. I recommend looking again at: http://webkit.org/coding/contributing.html If you're on windows, you'll need to look at: http://webkit.org/building/tools.html Adam Roben has always been very helpful to new windows contributers, but probably won't be very helpful if yelled at. :( You might also find #webkit on irc.freenode.net helpful. See: http://webkit.org/contact.html These changes are now over 30,000 revisions out of date, and are still not a patch. :o) Please feel free to attach an updated patch for review, but since the current changes clearly wouldn't cleanly apply to ToT I'm closing this bug for now. cheers, G. |