|Summary:||Microsoft Visual Studio 2008 (9.0) compatibility patch|
|Product:||WebKit||Reporter:||Eugene Lavrenov <evgenilv>|
|Severity:||Normal||CC:||aroben, barraclough, eric, laszlo.gombos, tonyg|
|Version:||528+ (Nightly build)|
Description Eugene Lavrenov 2010-02-10 20:45:21 PST
Comment 3 Adam Roben (:aroben) 2010-02-11 07:12:30 PST
Comment on attachment 48545 [details] Patch You should check the "patch" checkbox and set the "review" flag to "?" if you want a patch to be reviewed.
Comment 4 Adam Roben (:aroben) 2010-02-11 07:13:29 PST
Comment on attachment 48545 [details] Patch Also, please attach your patch as a unified diff. See <http://webkit.org/coding/contributing.html> for instructions.
Comment 5 Adam Roben (:aroben) 2010-02-11 07:23:43 PST
*** This bug has been marked as a duplicate of bug 34804 ***
Comment 6 Adam Roben (:aroben) 2010-02-11 07:26:34 PST
Since the compiler warnings are already covered by bug 34804, let's make this bug only be about build-webkit not working with VS2008 and VS2010. Please split up your work to fix these issues into two separate patches. Thanks!
Comment 7 Adam Roben (:aroben) 2010-02-11 12:40:37 PST
Comment on attachment 48545 [details] Patch As previously requested, please upload a unified diff instead of a zip file, as described here: <http://webkit.org/coding/contributing.html>. Also, please split this patch up into two pieces: one that fixes build-webkit (which should be attached to this bug), and one that fixes the compiler warnings (which should be attached to bug 34804).
Comment 8 Eugene Lavrenov 2010-02-11 13:20:45 PST
Comment 9 Eric Seidel (no email) 2010-02-17 16:01:39 PST
Comment on attachment 48545 [details] Patch This is not a patch file, it's a zip.
Comment 10 Eric Seidel (no email) 2010-02-17 16:04:56 PST
For better or worse, with 30-50 patches coming in to webkit.org every day, and there only being 30 or so active reviewers (not all of which are paid, as you claim), we just can't handle exceptions to the process. I recommend looking again at: http://webkit.org/coding/contributing.html If you're on windows, you'll need to look at: http://webkit.org/building/tools.html Adam Roben has always been very helpful to new windows contributers, but probably won't be very helpful if yelled at. :( You might also find #webkit on irc.freenode.net helpful. See: http://webkit.org/contact.html
Comment 11 Gavin Barraclough 2011-06-15 02:04:37 PDT
These changes are now over 30,000 revisions out of date, and are still not a patch. :o) Please feel free to attach an updated patch for review, but since the current changes clearly wouldn't cleanly apply to ToT I'm closing this bug for now. cheers, G.