|Summary:||[Android] Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded[|
|Product:||WebKit||Reporter:||Steve Block <steveblock>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||android-webkit-unforking, japhet, jorlow, steveblock|
|Version:||528+ (Nightly build)|
Description Steve Block 2010-02-10 15:14:34 PST
Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded These should be guarded with ENABLE(NOTIFICATIONS) and ENABLE(WEB_SOCKETS) This was introduced in http://trac.webkit.org/changeset/54150
Comment 2 Jeremy Orlow 2010-02-11 05:08:44 PST
Comment on attachment 48556 [details] Patch r=me because this seems to be what dave levin wanted...but I'm not sure if I agree this is better than putting guards around the includes. Will bring it up in the other bug.
Comment 3 Steve Block 2010-02-11 05:29:45 PST
Comment on attachment 48556 [details] Patch Clearing flags on attachment: 48556 Committed r54653: <http://trac.webkit.org/changeset/54653>
Comment 4 Steve Block 2010-02-11 05:29:54 PST
All reviewed patches have been landed. Closing bug.