Bug 34815

Summary: [Android] Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded[
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, japhet, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Steve Block
Reported 2010-02-10 15:14:34 PST
Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded These should be guarded with ENABLE(NOTIFICATIONS) and ENABLE(WEB_SOCKETS) This was introduced in http://trac.webkit.org/changeset/54150
Attachments
Patch (2.92 KB, patch)
2010-02-11 04:01 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-02-11 04:01:50 PST
Created attachment 48556 [details] Patch
Jeremy Orlow
Comment 2 2010-02-11 05:08:44 PST
Comment on attachment 48556 [details] Patch r=me because this seems to be what dave levin wanted...but I'm not sure if I agree this is better than putting guards around the includes. Will bring it up in the other bug.
Steve Block
Comment 3 2010-02-11 05:29:45 PST
Comment on attachment 48556 [details] Patch Clearing flags on attachment: 48556 Committed r54653: <http://trac.webkit.org/changeset/54653>
Steve Block
Comment 4 2010-02-11 05:29:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.