Bug 34806

Summary: [Android] Inspector headers in V8 ScriptObject.cpp are not correctly guarded
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, japhet, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch japhet: review+, steveblock: commit-queue-

Steve Block
Reported 2010-02-10 11:00:44 PST
Inspector headers in V8 ScriptObject.cpp are not correctly guarded These are generated headers so need to be guarded by ENABLE(INSPECTOR) They were added in http://trac.webkit.org/changeset/54305
Attachments
Patch (1.10 KB, patch)
2010-02-10 11:04 PST, Steve Block 		japhet: review+
steveblock: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-02-10 11:04:34 PST
Created attachment 48510 [details] Patch
Nate Chapin
Comment 2 2010-02-10 11:26:40 PST
Comment on attachment 48510 [details] Patch Sorry for breaking you :(
Steve Block
Comment 3 2010-02-10 16:15:29 PST
Comment on attachment 48510 [details] Patch Will update patch to avoid use of guards at header include sites. See Bug 34812.
Steve Block
Comment 4 2010-02-11 03:41:53 PST
Landed updated patch as http://trac.webkit.org/changeset/54651 Closing bug as resolved fixed.
Note You need to log in before you can comment on or make changes to this bug.