Summary: | Roll Chromium dependencies | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||||
Component: | WebKit API | Assignee: | Yury Semikhatsky <yurys> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | agl, dglazkov, pfeldman | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2010-02-10 02:52:07 PST
Created attachment 48479 [details]
patch
Rolling Chromium dependencies to match Chromium revision 38580
Comment on attachment 48479 [details]
patch
I believe these figures changed for a good reason :P
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/DEPS Committed r54594 Created attachment 48495 [details] patch base.gypi depends on third_party/nss on Windows(see http://src.chromium.org/viewvc/chrome?view=rev&revision=37289). This dependency breaks Chromium WebKit API build on Windows so I'm adding it to the DEPS. If you already have a dependency on base, why isn't that sufficient to pull in NSS? What actually breaks? (In reply to comment #5) > If you already have a dependency on base, why isn't that sufficient to pull in > NSS? What actually breaks? The problem is that NSS is not checked out in WebKit Chromium port build: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio Created attachment 48500 [details]
patch
> The problem is that NSS is not checked out in WebKit Chromium port build:
>
> http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio
Oh I see. Ok, thanks. LGTM. I am not a WebKit reviewer but, since this is a build break, you can just land it. (Or I can land it for you if you need.)
Created attachment 48503 [details]
patch
Same patch with nss URL fix.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/DEPS Committed r54598 |