Bug 34789

Summary: Roll Chromium dependencies
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: WebKit APIAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: agl, dglazkov, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch
pfeldman: review+
patch none

Yury Semikhatsky
Reported 2010-02-10 02:52:07 PST
WebKit/chromium/DEPS hasn't been updated for awhile.
Attachments
patch (1.33 KB, patch)
2010-02-10 03:08 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
patch (1.05 KB, patch)
2010-02-10 05:54 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
patch (1.20 KB, patch)
2010-02-10 06:45 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
patch (1.19 KB, patch)
2010-02-10 07:12 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-02-10 03:08:41 PST
Created attachment 48479 [details] patch Rolling Chromium dependencies to match Chromium revision 38580
Pavel Feldman
Comment 2 2010-02-10 03:11:16 PST
Comment on attachment 48479 [details] patch I believe these figures changed for a good reason :P
Yury Semikhatsky
Comment 3 2010-02-10 03:15:48 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/DEPS Committed r54594
Yury Semikhatsky
Comment 4 2010-02-10 05:54:54 PST
Created attachment 48495 [details] patch base.gypi depends on third_party/nss on Windows(see http://src.chromium.org/viewvc/chrome?view=rev&revision=37289). This dependency breaks Chromium WebKit API build on Windows so I'm adding it to the DEPS.
Adam Langley
Comment 5 2010-02-10 06:07:57 PST
If you already have a dependency on base, why isn't that sufficient to pull in NSS? What actually breaks?
Yury Semikhatsky
Comment 6 2010-02-10 06:33:45 PST
(In reply to comment #5) > If you already have a dependency on base, why isn't that sufficient to pull in > NSS? What actually breaks? The problem is that NSS is not checked out in WebKit Chromium port build: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio
Yury Semikhatsky
Comment 7 2010-02-10 06:45:19 PST
Created attachment 48500 [details] patch
Adam Langley
Comment 8 2010-02-10 06:53:04 PST
> The problem is that NSS is not checked out in WebKit Chromium port build: > > http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio Oh I see. Ok, thanks. LGTM. I am not a WebKit reviewer but, since this is a build break, you can just land it. (Or I can land it for you if you need.)
Yury Semikhatsky
Comment 9 2010-02-10 07:12:47 PST
Created attachment 48503 [details] patch Same patch with nss URL fix.
Yury Semikhatsky
Comment 10 2010-02-10 07:22:46 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/DEPS Committed r54598
Note You need to log in before you can comment on or make changes to this bug.