Bug 34786

Summary:

[Gtk] Make WebKit build on s390(x)

Product:

WebKit

Reporter:

Martin Stransky <stransky>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dan, eric, grant_gayed, jchaffraix, mrobinson, webkit.review.bot

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
s390(x) build patch	none
add support for s390(x)	none

Martin Stransky

Reported 2010-02-10 00:16:33 PST

Created attachment 48469 [details] s390(x) build patch Hi, there is a patch attached we use to build webkit on s390(x) boxes.

Attachments
s390(x) build patch (1.32 KB, patch) 2010-02-10 00:16 PST, Martin Stransky	no flags	Details Formatted Diff Diff
add support for s390(x) (1.33 KB, patch) 2010-11-11 04:00 PST, Dan Horák	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Stransky

Comment 1 2010-02-10 00:18:58 PST

For clarification: __s390x__ is 64bit __s390__ is 32bit and both are BIG_ENDIAN platform.

Julien Chaffraix

Comment 2 2010-03-16 22:55:35 PDT

Thanks for the patch. Though you should follow http://webkit.org/coding/contributing.html if you want your patch to be integrated. First make sure that you have a ChangeLog that explains the endian-ness issue. Also make sure you set the review flag to '?' or no reviewer will have a look at it.

Martin Robinson

Comment 3 2010-10-12 16:56:35 PDT

Martin, would you be willing to provide an updated patch for this issue against the SVN repository?

Dan Horák

Comment 4 2010-11-11 04:00:54 PST

Created attachment 73597 [details] add support for s390(x) rebased to recent SVN trunk

Andreas Kling

Comment 5 2010-11-11 04:23:04 PST

Comment on attachment 73597 [details] add support for s390(x) LGTM.

WebKit Commit Bot

Comment 6 2010-11-11 11:52:32 PST

The commit-queue encountered the following flaky tests while processing attachment 73597 [details]: fast/css/font-face-download-error.html http/tests/appcache/foreign-fallback.html Please file bugs against the tests. These tests were authored by ap@webkit.org and yuzo@google.com. The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 7 2010-11-11 12:55:58 PST

The commit-queue encountered the following flaky tests while processing attachment 73597 [details]: scrollbars/scrollbar-iframe-click-does-not-blur-content.html Please file bugs against the tests. These tests were authored by tonikitoo@webkit.org. The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 8 2010-11-11 12:58:16 PST

Comment on attachment 73597 [details] add support for s390(x) Clearing flags on attachment: 73597 Committed r71844: <http://trac.webkit.org/changeset/71844>

WebKit Commit Bot

Comment 9 2010-11-11 12:58:21 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 10 2010-11-11 14:03:03 PST

http://trac.webkit.org/changeset/71844 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/workers/storage/interrupt-database-sync.html

Note You need to log in before you can comment on or make changes to this bug.