Bug 34768

Summary:

[V8] Remove references to V8ClassIndex when possible

Product:

WebKit

Reporter:

Nate Chapin <japhet>

Component:

WebCore Misc.

Assignee:

Nate Chapin <japhet>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

33477

Attachments:

Description	Flags
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()	none

Description Nate Chapin 2010-02-09 11:30:33 PST

There are a bunch of places where we pass around V8ClassIndex::V8WrapperType parameters where we could (and probably should) be passing around other things that don't require a later lookup.  Usually this means passing a v8::Handle<v8::FunctionTemplate> instead.

Comment 1 Nate Chapin 2010-02-09 11:31:12 PST

Created attachment 48430 [details]
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()

Comment 2 Adam Barth 2010-02-09 12:07:18 PST

Comment on attachment 48430 [details]
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()

Great.  I've never liked V8ClassIndex.  Seemed so wrong to have a global list of classes like that.

Comment 3 Nate Chapin 2010-02-10 16:10:28 PST

Comment on attachment 48430 [details]
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()

http://trac.webkit.org/changeset/54629

Comment 4 Nate Chapin 2010-03-10 14:56:49 PST

I think most of the unnecessary references to V8ClassIndex have been removed, and the rest are feasible to take care of in the patch that deletes V8Index.h.