Bug 34768

Summary:

[V8] Remove references to V8ClassIndex when possible

Product:

WebKit

Reporter:

Nate Chapin <japhet>

Component:

WebCore Misc.

Assignee:

Nate Chapin <japhet>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

33477

Attachments:

Description	Flags
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()	none

Nate Chapin

Reported 2010-02-09 11:30:33 PST

There are a bunch of places where we pass around V8ClassIndex::V8WrapperType parameters where we could (and probably should) be passing around other things that don't require a later lookup. Usually this means passing a v8::Handle<v8::FunctionTemplate> instead.

Attachments
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() (21.06 KB, patch) 2010-02-09 11:31 PST, Nate Chapin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Nate Chapin

Comment 1 2010-02-09 11:31:12 PST

Created attachment 48430 [details] Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()

Adam Barth

Comment 2 2010-02-09 12:07:18 PST

Comment on attachment 48430 [details] Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() Great. I've never liked V8ClassIndex. Seemed so wrong to have a global list of classes like that.

Nate Chapin

Comment 3 2010-02-10 16:10:28 PST

Comment on attachment 48430 [details] Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() http://trac.webkit.org/changeset/54629

Nate Chapin

Comment 4 2010-03-10 14:56:49 PST

I think most of the unnecessary references to V8ClassIndex have been removed, and the rest are feasible to take care of in the patch that deletes V8Index.h.

Note You need to log in before you can comment on or make changes to this bug.