Bug 34754

Summary: [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
setadjforframeview.diff gustavo: review+, xan.lopez: commit-queue-

Xan Lopez
Reported 2010-02-09 07:47:56 PST
Right now we only do this in FrameLoaderClient::transitionToCommittedForNewPage, which is only called when we load uncached pages. If the page we are about to load is in the cache rameLoaderClient::transitionToCommittedFromCachedFrame is called instead, and we never set the adjustments. This results in the scrollbars for the main frame being mispositioned and nonfunctional in some cases.
Attachments
setadjforframeview.diff (4.12 KB, patch)
2010-02-09 07:52 PST, Xan Lopez 		gustavo: review+
xan.lopez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-02-09 07:52:59 PST
Created attachment 48414 [details] setadjforframeview.diff
WebKit Review Bot
Comment 2 2010-02-09 07:55:58 PST
Attachment 48414 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1131: Use 0 instead of NULL. [readability/null] [5] WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1142: Declaration has space between type name and * in Frame *frame [whitespace/declaration] [3] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
Gustavo Noronha (kov)
Comment 3 2010-02-09 10:18:59 PST
Comment on attachment 48414 [details] setadjforframeview.diff r=me with the style issues reported by the bot fixed! =)
Xan Lopez
Comment 4 2010-02-09 10:23:43 PST
All done in r54559.
Note You need to log in before you can comment on or make changes to this bug.