Summary: | [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Xan Lopez
2010-02-09 07:47:56 PST
Created attachment 48414 [details]
setadjforframeview.diff
Attachment 48414 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1131: Use 0 instead of NULL. [readability/null] [5]
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1142: Declaration has space between type name and * in Frame *frame [whitespace/declaration] [3]
Total errors found: 2
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 48414 [details]
setadjforframeview.diff
r=me with the style issues reported by the bot fixed! =)
|