Summary: | Web Inspector: Continue with debugger and profiler unforking | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, dglazkov, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Mikhail Naganov
2010-02-08 09:04:43 PST
Created attachment 48335 [details]
proposed patch
Attachment 48335 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/244785 Comment on attachment 48335 [details]
proposed patch
r- for the bot failure.
+ #elif ENABLE(JAVASCRIPT_DEBUGGER)
+ , m_profilerEnabled(true)
It would be more clear if m_profilerEnabled was mentioned only once and resided in a simple ENABLE(JAVASCRIPT_DEBUGGER) section.
Also please do not mix formatting with changes that heavily.
Created attachment 48405 [details]
comment addressed, removed style changes, fixed chromium port
Attachment 48405 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/250407 Created attachment 48406 [details]
really fixed chromimum port
Comment on attachment 48406 [details] really fixed chromimum port Clearing flags on attachment: 48406 Committed r54576: <http://trac.webkit.org/changeset/54576> All reviewed patches have been landed. Closing bug. |