Bug 34704

Summary: [v8] Use v8::Debug::ProcessDebugMessages instead of executing an empty function
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, pfeldman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
pfeldman: review+
patch that I'm going to land none

Yury Semikhatsky
Reported 2010-02-08 05:40:44 PST
v8 API now has a method for forcing debug command processing. We should use it instead of executing empty function to trigger JS execution.
Attachments
patch (5.68 KB, patch)
2010-02-08 05:43 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
patch that I'm going to land (10.82 KB, patch)
2010-02-10 00:23 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-02-08 05:43:45 PST
Created attachment 48328 [details] patch
WebKit Review Bot
Comment 2 2010-02-08 05:58:10 PST
Attachment 48328 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/245261
Yury Semikhatsky
Comment 3 2010-02-10 00:23:18 PST
Created attachment 48470 [details] patch that I'm going to land The patch includes changes to the recently upstreamed *.js files.
Yury Semikhatsky
Comment 4 2010-02-10 02:26:11 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/src/DebuggerAgent.h M WebKit/chromium/src/DebuggerAgentImpl.cpp M WebKit/chromium/src/DebuggerAgentImpl.h M WebKit/chromium/src/ToolsAgent.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h M WebKit/chromium/src/js/DebuggerAgent.js M WebKit/chromium/src/js/DevToolsHostStub.js M WebKit/chromium/src/js/InjectDispatch.js M WebKit/chromium/src/js/ProfilerAgent.js M WebKit/chromium/src/js/Tests.js Committed r54592
Note You need to log in before you can comment on or make changes to this bug.