Summary: | Simplified RuntimeEnabledFeatures and corresponding v8 generated code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yaar Schnitman <yaar> | ||||||||
Component: | New Bugs | Assignee: | Yaar Schnitman <yaar> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | atwilson, commit-queue, dominicc, eric, jorlow | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Yaar Schnitman
2010-02-05 15:59:14 PST
Created attachment 48272 [details]
Patch
Created attachment 48363 [details]
Ready for Review
Created attachment 48365 [details]
Updated patch
Comment on attachment 48365 [details]
Updated patch
Merged problems broke style & AWS...
Removing whitespace makes this patch needlessly large. Why change Database to DB? We tend to use full english words when possible in WebKit (obviously not HyperTextMarkupLanguage. :) (In reply to comment #5) > Removing whitespace makes this patch needlessly large. Sorry about that, but I understand whitespace changes are ok in files I have other edits. They are very trivial though. > Why change Database to DB? We tend to use full english words when possible in > WebKit (obviously not HyperTextMarkupLanguage. :) I know, but the corresponding JS method this method enabled/disables is named IndexedDB, not IndexedDatabase. For code-generation and low maintenance reasons, the enabler and the JS method must correspond. Comment on attachment 48365 [details]
Updated patch
LGTM
Comment on attachment 48365 [details] Updated patch Clearing flags on attachment: 48365 Committed r54593: <http://trac.webkit.org/changeset/54593> All reviewed patches have been landed. Closing bug. |