Bug 34664

Summary: [Chromium] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebKit APIAssignee: James Hawkins <jhawkins>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient
none
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try2]
none
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try3]
none
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try4]
none
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try5]
none
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6]
fishd: review-
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7] none

Description James Hawkins 2010-02-05 14:50:07 PST
Patch will follow.
Comment 1 James Hawkins 2010-02-05 14:52:13 PST
Created attachment 48263 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient
Comment 2 WebKit Review Bot 2010-02-05 14:56:14 PST
Attachment 48263 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/240009
Comment 3 James Hawkins 2010-02-05 14:59:03 PST
Created attachment 48264 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try2]

Forgot an occurrence of autocompletePopupDidHide.
Comment 4 James Hawkins 2010-02-05 15:02:32 PST
Created attachment 48265 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try3]

Forgot to update the Changelog.
Comment 5 WebKit Review Bot 2010-02-05 15:03:31 PST
Attachment 48264 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/238371
Comment 6 WebKit Review Bot 2010-02-05 15:06:23 PST
Attachment 48265 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/240022
Comment 7 James Hawkins 2010-02-05 15:10:27 PST
Created attachment 48266 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try4]

Add back suggestionsPopupDidHide.
Comment 8 WebKit Review Bot 2010-02-05 15:14:20 PST
Attachment 48266 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/240032
Comment 9 James Hawkins 2010-02-05 15:23:05 PST
Created attachment 48267 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try5]

More build fixes...yikes.
Comment 10 WebKit Review Bot 2010-02-05 15:26:33 PST
Attachment 48267 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/238397
Comment 11 James Hawkins 2010-02-05 15:34:12 PST
Created attachment 48268 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6]

Last one?
Comment 12 Darin Fisher (:fishd, Google) 2010-02-05 16:05:55 PST
Comment on attachment 48268 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6]

> Index: WebKit/chromium/public/WebView.h

> -    // Hides the autofill popup if any are showing.
> -    virtual void hideAutofillPopup() = 0;
> +    // Hides the suggestions popup if any are showing.
> +    virtual void hideSuggestionsPopup() = 0;

Please preserve the old API, and add a comment marking it DEPRECATED.

You can just make your code call both functions for now.  Then, once
Chromium is updated to use the new function, you can come back and
delete the deprecated one.

Otherwise, LGTM.
Comment 13 James Hawkins 2010-02-05 16:12:10 PST
Created attachment 48274 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7]

Adds back a deprecated hideAutofillPopup.
Comment 14 WebKit Commit Bot 2010-02-05 18:45:00 PST
Comment on attachment 48274 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7]

Clearing flags on attachment: 48274

Committed r54458: <http://trac.webkit.org/changeset/54458>
Comment 15 WebKit Commit Bot 2010-02-05 18:45:11 PST
All reviewed patches have been landed.  Closing bug.