Bug 34664 – [Chromium] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient

• Component: WebKit API
• Status: RESOLVED FIXED

[James Hawkins]

Patch will follow.

[James Hawkins]

Created attachment 48263 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient

[WebKit Review Bot]

Attachment 48263 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/240009

[James Hawkins]

Created attachment 48264 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try2]

Forgot an occurrence of autocompletePopupDidHide.

[James Hawkins]

Created attachment 48265 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try3]

Forgot to update the Changelog.

[WebKit Review Bot]

Attachment 48264 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/238371

[WebKit Review Bot]

Attachment 48265 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/240022

[James Hawkins]

Created attachment 48266 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try4]

Add back suggestionsPopupDidHide.

[WebKit Review Bot]

Attachment 48266 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/240032

[James Hawkins]

Created attachment 48267 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try5]

More build fixes...yikes.

[WebKit Review Bot]

Attachment 48267 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/238397

[James Hawkins]

Created attachment 48268 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6]

Last one?

[Darin Fisher (:fishd, Google)]

Comment on attachment 48268 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6]

> Index: WebKit/chromium/public/WebView.h

> -    // Hides the autofill popup if any are showing.
> -    virtual void hideAutofillPopup() = 0;
> +    // Hides the suggestions popup if any are showing.
> +    virtual void hideSuggestionsPopup() = 0;

Please preserve the old API, and add a comment marking it DEPRECATED.

You can just make your code call both functions for now.  Then, once
Chromium is updated to use the new function, you can come back and
delete the deprecated one.

Otherwise, LGTM.

[James Hawkins]

Created attachment 48274 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7]

Adds back a deprecated hideAutofillPopup.

[WebKit Commit Bot]

Comment on attachment 48274 [details]
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7]

Clearing flags on attachment: 48274

Committed r54458: <http://trac.webkit.org/changeset/54458>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.