Summary: | [chromium] Change chromium interface to handle DownloadURL format. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jian Li <jianli> | ||||
Component: | WebKit Misc. | Assignee: | Jian Li <jianli> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dimich, fishd | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jian Li
2010-02-05 11:12:19 PST
Created attachment 48244 [details]
Proposed Patch
Comment on attachment 48244 [details] Proposed Patch > +++ b/WebCore/platform/chromium/ChromiumDataObject.cpp > @@ -38,6 +38,7 @@ void ChromiumDataObject::clear() > url = KURL(); > urlTitle = ""; > downloadURL = KURL(); > + downloadMetadata = ""; nit: should be "downloadMetaData" <-- cap "Data" > +++ b/WebKit/chromium/public/WebDragData.h > @@ -74,6 +74,8 @@ public: > > WEBKIT_API WebURL downloadURL() const; > WEBKIT_API void setDownloadURL(const WebURL&); > + WEBKIT_API WebString downloadMetadata() const; > + WEBKIT_API void setDownloadMetadata(const WebString&); same nit: should be named downloadMetaData and setDownloadMetaData otherwise, this LGTM Actually, I take it back. http://en.wikipedia.org/wiki/Metadata seems to strongly favor the spelling you used. I had always thought of it as two words combined meta plus data, but I guess I was wrong. Comment on attachment 48244 [details]
Proposed Patch
R=me (I'm also doing CQ+ since this shouldn't break the Chromium build.)
Comment on attachment 48244 [details] Proposed Patch Clearing flags on attachment: 48244 Committed r54469: <http://trac.webkit.org/changeset/54469> All reviewed patches have been landed. Closing bug. |