Summary: | update-webkit-auxiliary-libs does not like a space in the path to the WebKit folder | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leith Bade <leith> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Leith Bade
2010-02-05 02:02:52 PST
It would appear that both environment variables WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR are set incorrectly. WEBKITOUTPUTDIR was C:\home\cygwin\Leith which does not exist ("C:\home\cygwin\Leith Bade" does). Don't suppose this is related to the change for #31228 ? I have traced it down to whatever sets the WEBKITLIBRARIESDIR environment variable in the registry. It seems to replace the space with a newline wen it sets the reg key. OK it seems putting quotes around $WEBKITLIBRARIESDIR fixes the problem. eg cygpath -u "$WEBKITLIBRARIESDIR" otherwise cygpath treats the space as seperating two different paths to convert hence why it puts each respective path on a new line in it's output. Created attachment 48301 [details]
Proposed patch.
I forgot to put a fix in for the "The WebKitAuxiliaryLibrary has been sucessfully installed in" bug. This might need to go under a different bug #? (I am not familiar enough with Perl to confidently make that change) Also in order to support Visual Studio, there needs to be a trailing '\' in the environment variable. Comment on attachment 48301 [details]
Proposed patch.
Now we can handle paths with spaces, but not ones with single quotes. A step in the right direction, I guess.
(In reply to comment #8) > (From update of attachment 48301 [details]) > Now we can handle paths with spaces, but not ones with single quotes. A step in > the right direction, I guess. Yeah I suppose some people might have a `'` in their user name. Ag. "Leith's Computer" or something like that. Double quotes could fix this... As `"` is an illegal filename char in Windows. I note that in webkitdirs.pm there is an inconsistent use of cygpath. Some use `'`, some use `"` and some even do no quotes at all... Should the entire file be cleaned up to use only `"`? Comment on attachment 48301 [details] Proposed patch. Clearing flags on attachment: 48301 Committed r54477: <http://trac.webkit.org/changeset/54477> All reviewed patches have been landed. Closing bug. |