Bug 34635 – [Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly

• Component: New Bugs
• Status: RESOLVED FIXED

Created attachment 48211 [details]
Fix for the problem

When QWebView has a different style set on it then the scrollbars are not rendered correctly on the Mac, only the buttons are rendered but not the actual slider.

This can reproduced with the demo Qt browser and running it with a style such as plastique.

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords

[Alexis Menard (darktears)]

Created attachment 94467 [details]
Patch

[Alexis Menard (darktears)]

*** Bug 35681 has been marked as a duplicate of this bug. ***

[Benjamin Poulain]

Comment on attachment 94467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94467&action=review

> Source/WebCore/platform/qt/ScrollbarThemeQt.cpp:159
> +    if (qobject_cast<QMacStyle *>(QApplication::style()))

Application::style()? What if the widget has a different style than the default style?

[Alexis Menard (darktears)]

Created attachment 94628 [details]
Patch

[Alexis Menard (darktears)]

Created attachment 94641 [details]
Patch

[Antonio Gomes]

Comment on attachment 94641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94641&action=review

> Source/WebCore/ChangeLog:9
> +        two paths one for Mac and one for any other styles. The problem is that on Mac you can still run the

needs a comma after "two paths"

> Source/WebCore/platform/qt/ScrollbarThemeQt.cpp:161
> +    if (qobject_cast<QMacStyle *>(style()))

unneeded space.

> Source/WebCore/platform/qt/ScrollbarThemeQt.cpp:170
> +        // The QStyle expects the background to be already filled

missing dot in the end.

[Alexis Menard (darktears)]

Committed r87290: <http://trac.webkit.org/changeset/87290>

[Ademar Reis]

Revision r87290 cherry-picked into qtwebkit-2.2 with commit 5087eaa <http://gitorious.org/webkit/qtwebkit/commit/5087eaa>