Bug 34625

Summary: editing/execCommand/indent-paragraphs.html is missing pixel test results
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, commit-queue, darin, enrica, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2010-02-04 17:29:51 PST
editing/execCommand/indent-paragraphs.html is missing pixel test results
Attachments
Patch (62.82 KB, patch)
2010-02-04 17:32 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (8.90 KB, patch)
2010-02-07 18:21 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-02-04 17:32:02 PST
Created attachment 48184 [details] Patch
Darin Adler
Comment 2 2010-02-05 06:58:54 PST
But since this test puts the markup into the page, it probably should have just been a dumpAsText test in the first place.
WebKit Commit Bot
Comment 3 2010-02-05 08:34:09 PST
Comment on attachment 48184 [details] Patch Rejecting patch 48184 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... RA layer request failed: PROPFIND request failed on '/repository/webkit/trunk': PROPFIND of '/repository/webkit/trunk': timed out waiting for server (http://svn.webkit.org) at /usr/local/git/libexec/git-core/git-svn line 557 Full output: http://webkit-commit-queue.appspot.com/results/238136
Eric Seidel (no email)
Comment 4 2010-02-05 12:03:10 PST
Attachment 48184 [details] was posted by a committer and has review+, assigning to Tony Chang for commit.
Tony Chang
Comment 5 2010-02-07 18:21:29 PST
Created attachment 48311 [details] Patch
Tony Chang
Comment 6 2010-02-07 18:22:07 PST
(In reply to comment #2) > But since this test puts the markup into the page, it probably should have just > been a dumpAsText test in the first place. Yes, that would be better. I've switched it to a dumpAsText() test.
WebKit Commit Bot
Comment 7 2010-02-08 03:04:43 PST
Comment on attachment 48311 [details] Patch Clearing flags on attachment: 48311 Committed r54478: <http://trac.webkit.org/changeset/54478>
WebKit Commit Bot
Comment 8 2010-02-08 03:04:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.