Bug 34618

Summary:

Make MathExtras.h compatible with <cmath>

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	levin: review+

Description Darin Adler 2010-02-04 14:23:04 PST

Make MathExtras.h compatible with <cmath>

Comment 1 Darin Adler 2010-02-04 14:25:59 PST

Created attachment 48171 [details]
Patch

Comment 2 WebKit Review Bot 2010-02-04 14:29:48 PST

Attachment 48171 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/MathExtras.h:189:  Use 'using namespace std;' instead of 'using std::isfinite;'.  [build/using_std] [4]
JavaScriptCore/wtf/MathExtras.h:190:  Use 'using namespace std;' instead of 'using std::isinf;'.  [build/using_std] [4]
JavaScriptCore/wtf/MathExtras.h:191:  Use 'using namespace std;' instead of 'using std::isnan;'.  [build/using_std] [4]
JavaScriptCore/wtf/MathExtras.h:192:  Use 'using namespace std;' instead of 'using std::signbit;'.  [build/using_std] [4]
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Darin Adler 2010-02-04 17:01:58 PST

Committed r54388: <http://trac.webkit.org/changeset/54388>