Bug 34618

Summary: Make MathExtras.h compatible with <cmath>
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch levin: review+

Darin Adler
Reported 2010-02-04 14:23:04 PST
Make MathExtras.h compatible with <cmath>
Attachments
Patch (1.74 KB, patch)
2010-02-04 14:25 PST, Darin Adler 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-02-04 14:25:59 PST
Created attachment 48171 [details] Patch
WebKit Review Bot
Comment 2 2010-02-04 14:29:48 PST
Attachment 48171 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/MathExtras.h:189: Use 'using namespace std;' instead of 'using std::isfinite;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:190: Use 'using namespace std;' instead of 'using std::isinf;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:191: Use 'using namespace std;' instead of 'using std::isnan;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:192: Use 'using namespace std;' instead of 'using std::signbit;'. [build/using_std] [4] Total errors found: 4 If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2010-02-04 17:01:58 PST
Committed r54388: <http://trac.webkit.org/changeset/54388>
Note You need to log in before you can comment on or make changes to this bug.