Bug 34600 – [BREWMP] Port PlatformMouseEvent

• Component: Platform
• Status: RESOLVED FIXED

[Kwang Yul Seo]

Port PlatformMouseEvent to BREWMP.

[Kwang Yul Seo]

Created attachment 48150 [details]
Patch

Retrieve the event type, position, key modifiers, time stamp and click count from AEEEvent.

[Kwang Yul Seo]

Created attachment 48151 [details]
Patch

Sort header files alphabetically.

[WebKit Review Bot]

Attachment 48150 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/brew/PlatformMouseEventBrew.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 48151 [details]
Patch

> Index: WebCore/platform/PlatformMouseEvent.h
> @@ -55,6 +55,12 @@ class wxMouseEvent;
>  class BMessage;
>  #endif
>  
> +#if PLATFORM(BREWMP)
> +typedef unsigned short    uint16;
> +typedef unsigned long int uint32;
> +#define AEEEvent uint16

Why doesn't this use a typedef (instead of a define)?

> +#if PLATFORM(BREWMP)
> +        PlatformMouseEvent(AEEEvent event, uint16 wParam, uint32 dwParam);

The param name event is not needed here.

[Kwang Yul Seo]

(In reply to comment #4)
> (From update of attachment 48151 [details])
> > Index: WebCore/platform/PlatformMouseEvent.h
> > @@ -55,6 +55,12 @@ class wxMouseEvent;
> >  class BMessage;
> >  #endif
> >  
> > +#if PLATFORM(BREWMP)
> > +typedef unsigned short    uint16;
> > +typedef unsigned long int uint32;
> > +#define AEEEvent uint16
> 
> Why doesn't this use a typedef (instead of a define)?

Because AEEEvent.h defines AEEEvent to uint16.

#define AEEEvent  uint16

> 
> > +#if PLATFORM(BREWMP)
> > +        PlatformMouseEvent(AEEEvent event, uint16 wParam, uint32 dwParam);
> 
> The param name event is not needed here.

Okay.

[Kwang Yul Seo]

Created attachment 48280 [details]
Patch

Remove the param name event from PlatformMouseEvent constructor declaration.

[WebKit Review Bot]

Attachment 48280 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/brew/PlatformMouseEventBrew.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kwang Yul Seo]

Created attachment 48282 [details]
Patch

Remove style errors.

[WebKit Review Bot]

Attachment 48282 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/238598

[Kwang Yul Seo]

(In reply to comment #9)
> Attachment 48282 [details] did not build on chromium:
> Build output: http://webkit-commit-queue.appspot.com/results/238598

It seems the chromium build error is unrelated to this patch.

[Adam Barth]

Comment on attachment 48282 [details]
Patch

Sorry about the Chromium build error.  The bot was having some trouble.  I'm not an expert on platform mouse events, but this patch looks reasonable to me.

[WebKit Commit Bot]

Comment on attachment 48282 [details]
Patch

Clearing flags on attachment: 48282

Committed r54583: <http://trac.webkit.org/changeset/54583>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.