Bug 34597

Summary: [Qt] Build break in QtWebkit on Symbian
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: hausmann, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
Fixing erroneous removal of OS(SYMBIAN) ariya.hidayat: review+, hausmann: commit-queue-

Siddharth Mathur
Reported 2010-02-04 08:57:45 PST
r53955 causes build break in QtWebkit/Symbian. Notice the change from OS(SYMBIAN) to PLATFORM(SYMBIAN). It seems it is unrelated to the GTK2-related theme of Bug 18831 : https://bugs.webkit.org/attachment.cgi?id=47166&action=diff#a/WebCore/plugins/PluginView.h_sec3 Error message is for WebCore\plugins\symbian\PluginViewSymbian.cpp Error: #20: identifier "setNPWindowIfNeeded" is undefined setNPWindowIfNeeded();
Attachments
Fixing erroneous removal of OS(SYMBIAN) (978 bytes, patch)
2010-02-04 15:27 PST, Siddharth Mathur 		ariya.hidayat: review+
hausmann: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Siddharth Mathur
Comment 1 2010-02-04 15:27:48 PST
Created attachment 48177 [details] Fixing erroneous removal of OS(SYMBIAN) Fixing erroneous removal of OS(SYMBIAN).
Ariya Hidayat
Comment 2 2010-02-04 16:43:24 PST
Comment on attachment 48177 [details] Fixing erroneous removal of OS(SYMBIAN) LGTM.
Simon Hausmann
Comment 3 2010-02-05 02:28:52 PST
Comment on attachment 48177 [details] Fixing erroneous removal of OS(SYMBIAN) I agree that this is a no-brainer :) > + No new tests. (OOPS!) But please remove this line when landing :)
Simon Hausmann
Comment 4 2010-02-05 06:10:38 PST
Committed r54422: <http://trac.webkit.org/changeset/54422>
Note You need to log in before you can comment on or make changes to this bug.