Bug 34593

Summary:

Bug in V8 convertNPVariantToJValue when converting float and double types

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
Patch	none

Description Steve Block 2010-02-04 08:04:53 PST

V8 convertNPVariantToJValue has a bug when converting float and double types.
The wrong element of the 'result' enum is used in these cases.
We should use result.f for floats, and result.d for doubles.

Comment 1 Steve Block 2010-02-04 09:51:29 PST

Created attachment 48152 [details]
Patch

Comment 2 WebKit Commit Bot 2010-02-04 13:19:25 PST

Comment on attachment 48152 [details]
Patch

Clearing flags on attachment: 48152

Committed r54366: <http://trac.webkit.org/changeset/54366>

Comment 3 WebKit Commit Bot 2010-02-04 13:19:31 PST

All reviewed patches have been landed.  Closing bug.