Bug 34593

Summary: Bug in V8 convertNPVariantToJValue when converting float and double types
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Steve Block
Reported 2010-02-04 08:04:53 PST
V8 convertNPVariantToJValue has a bug when converting float and double types. The wrong element of the 'result' enum is used in these cases. We should use result.f for floats, and result.d for doubles.
Attachments
Patch (2.07 KB, patch)
2010-02-04 09:51 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-02-04 09:51:29 PST
Created attachment 48152 [details] Patch
WebKit Commit Bot
Comment 2 2010-02-04 13:19:25 PST
Comment on attachment 48152 [details] Patch Clearing flags on attachment: 48152 Committed r54366: <http://trac.webkit.org/changeset/54366>
WebKit Commit Bot
Comment 3 2010-02-04 13:19:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.