Bug 34593 - Bug in V8 convertNPVariantToJValue when converting float and double types
Summary: Bug in V8 convertNPVariantToJValue when converting float and double types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 08:04 PST by Steve Block
Modified: 2010-02-04 13:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2010-02-04 09:51 PST, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-04 08:04:53 PST 
V8 convertNPVariantToJValue has a bug when converting float and double types.
The wrong element of the 'result' enum is used in these cases.
We should use result.f for floats, and result.d for doubles.
Comment 1 Steve Block 2010-02-04 09:51:29 PST 
Created attachment 48152 [details]
Patch
Comment 2 WebKit Commit Bot 2010-02-04 13:19:25 PST 
Comment on attachment 48152 [details]
Patch

Clearing flags on attachment: 48152

Committed r54366: <http://trac.webkit.org/changeset/54366>
Comment 3 WebKit Commit Bot 2010-02-04 13:19:31 PST 
All reviewed patches have been landed.  Closing bug.