Bug 34572

Summary: [Gtk] Implement layoutTestController.pageNumberForElementById
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Shinichiro Hamaji <hamaji>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gustavo, hayato, webkit.review.bot, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch v1 none

Shinichiro Hamaji
Reported 2010-02-04 03:59:17 PST
This was added in Bug 33840.
Attachments
Patch v1 (5.49 KB, patch)
2010-02-04 04:01 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-02-04 04:01:06 PST
Created attachment 48131 [details] Patch v1
WebKit Review Bot
Comment 2 2010-02-04 04:04:33 PST
Attachment 48131 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
Shinichiro Hamaji
Comment 3 2010-02-04 04:24:24 PST
(In reply to comment #2) > Attachment 48131 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: > webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use > underscores in your identifier names. [readability/naming] [4] > WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. > [readability/null] [5] > Total errors found: 2 Looks like these files should be in the exception list of our style checker?
Gustavo Noronha (kov)
Comment 4 2010-02-05 03:52:53 PST
Comment on attachment 48131 [details] Patch v1 I was going to say the function name lacked a 'get' somewhere, to be consistent, but I see we have previous cases of that; we might want to review all of them while exposing. Thanks for the patch!
Gustavo Noronha (kov)
Comment 5 2010-02-05 03:53:49 PST
(In reply to comment #3) > (In reply to comment #2) > > Attachment 48131 [details] [details] did not pass style-queue: > > > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: > > webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use > > underscores in your identifier names. [readability/naming] [4] > > WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. > > [readability/null] [5] > > Total errors found: 2 > > Looks like these files should be in the exception list of our style checker? Indeed. Rules here should be the same as for WebKit/gtk/
Eric Seidel (no email)
Comment 6 2010-02-05 12:03:04 PST
Attachment 48131 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Shinichiro Hamaji
Comment 7 2010-02-05 21:38:11 PST
Comment on attachment 48131 [details] Patch v1 Clearing flags on attachment: 48131 Committed r54461: <http://trac.webkit.org/changeset/54461>
Shinichiro Hamaji
Comment 8 2010-02-05 21:38:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.