Bug 34570

Summary: [Win] Implement test functions for printing
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, eric, hayato, sfalken, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Shinichiro Hamaji
Reported 2010-02-04 03:28:27 PST
This was added in Bug 33840.
Attachments
Patch v1 (5.98 KB, patch)
2010-02-04 03:32 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Patch v2 (7.47 KB, patch)
2010-02-16 00:51 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-02-04 03:32:25 PST
Created attachment 48127 [details] Patch v1
Shinichiro Hamaji
Comment 2 2010-02-16 00:51:09 PST
Renaming title: "[Win] Implement layoutTestController.pageNumberForElementById" => "[Win] Implement test functions for printing" . As the implementation of layoutTestController.numberOfPages added in Bug 34699 is similar to layoutTestController.pageNumberForElementById, it would make sense to implement them at once.
Shinichiro Hamaji
Comment 3 2010-02-16 00:51:32 PST
Created attachment 48793 [details] Patch v2
Eric Seidel (no email)
Comment 4 2010-02-17 15:50:25 PST
Comment on attachment 48793 [details] Patch v2 Adam or Steve are your best reviewers here, but this looks sane to me.
Shinichiro Hamaji
Comment 5 2010-02-17 18:42:14 PST
Comment on attachment 48793 [details] Patch v2 Clearing flags on attachment: 48793 Committed r54921: <http://trac.webkit.org/changeset/54921>
Shinichiro Hamaji
Comment 6 2010-02-17 18:42:22 PST
All reviewed patches have been landed. Closing bug.
Shinichiro Hamaji
Comment 7 2010-02-17 19:35:04 PST
Hmm... My change broke the build. http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/11159/steps/compile-webkit/logs/stdio I guess it happened because the change for IWebFramePrivate.idl wasn't handled and just re-generating WebKitBuild/include/WebKit/WebKit.h will fix the build. Are there any way to re-generate the file?
Shinichiro Hamaji
Comment 8 2010-02-17 20:19:17 PST
Committed r54922: <http://trac.webkit.org/changeset/54922>
Note You need to log in before you can comment on or make changes to this bug.