Bug 34563

Summary: websocket/tests/close-on-unload.html failed on Mac Tiger
Product: WebKit Reporter: Fumitoshi Ukai <ukai>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.3   
Attachments:
Description Flags
Patch hamaji: review+

Fumitoshi Ukai
Reported 2010-02-03 23:23:06 PST
since r54319, websocket/tests/close-on-unload.html failed on Mac Tiger. This is because python is old on the platform (no set() available) http://build.webkit.org/results/Tiger%20Intel%20Release/r54323%20(8478)/pywebsocket_log.txt
Attachments
Patch (2.21 KB, patch)
2010-02-04 01:18 PST, Fumitoshi Ukai 		hamaji: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1 2010-02-04 01:18:58 PST
Created attachment 48115 [details] Patch
Shinichiro Hamaji
Comment 2 2010-02-04 04:07:31 PST
Comment on attachment 48115 [details] Patch Looks good except for a few nitpicks. > -connections = set() > +connections = {} I'd comment why we don't use set() here so people don't make this fail again. > + for ws in connections.keys(): I slightly prefer iterkeys() but it's OK as is.
Fumitoshi Ukai
Comment 3 2010-02-04 21:59:57 PST
Committed r54404: <http://trac.webkit.org/changeset/54404>
Note You need to log in before you can comment on or make changes to this bug.