Bug 34559

Summary:

[Qt] Unnecessary QBrush construction for doing a solid fill

Product:

WebKit

Reporter:

Ariya Hidayat <ariya.hidayat>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	hausmann: review+

Description Ariya Hidayat 2010-02-03 21:28:01 PST

Created attachment 48097 [details]
Patch

Setting the fill to a solid color forces a construction of QBrush (which is expensive).

Comment 1 Ariya Hidayat 2010-02-03 21:38:34 PST

Created attachment 48101 [details]
Patch

Comment 2 Simon Hausmann 2010-02-04 02:35:17 PST

Comment on attachment 48101 [details]
Patch

Good idea! :)

Comment 3 Ariya Hidayat 2010-02-04 09:44:06 PST

Manually committed r54347: in http://trac.webkit.org/changeset/54347