Bug 34551

Summary: WorkerContext.close() does not work in the chromium port
Product: WebKit Reporter: Andrew Wilson <atwilson>
Component: WebCore JavaScriptAssignee: Andrew Wilson <atwilson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dimich, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Andrew Wilson
Reported 2010-02-03 18:22:37 PST
We do not shutdown the Worker thread in the chromium port when the thread calls close(). This means that code like this: var worker = new Worker("worker.js"); worker.js: close(); Will leave the thread running until the parent window shuts down. There's code in Chromium to prevent further messages from being to/from the closing thread, but the thread itself still sits there.
Attachments
Patch (1.19 KB, patch)
2010-02-04 15:09 PST, Andrew Wilson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Wilson
Comment 1 2010-02-04 15:09:39 PST
Created attachment 48172 [details] Patch
WebKit Commit Bot
Comment 2 2010-02-04 15:43:30 PST
Comment on attachment 48172 [details] Patch Clearing flags on attachment: 48172 Committed r54380: <http://trac.webkit.org/changeset/54380>
WebKit Commit Bot
Comment 3 2010-02-04 15:43:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.