Bug 34542

Summary: wx port: client cannot interrupt or modify new windows
Product: WebKit Reporter: Kevin Watters <kevinwatters>
Component: WebKit wxAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kevino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
fires a wx event in createWindow kevino: review+, kevino: commit-queue-

Description Kevin Watters 2010-02-03 15:17:45 PST
Created attachment 48069 [details]
fires a wx event in createWindow

ChomeClient's createWindow has a FIXME about firing an veto-able event.
Comment 1 WebKit Review Bot 2010-02-03 15:24:12 PST
Attachment 48069 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/wx/WebView.h:307:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Kevin Ollivier 2010-02-03 16:16:12 PST
Landed in r54309, thanks!