Bug 34542 - wx port: client cannot interrupt or modify new windows
: wx port: client cannot interrupt or modify new windows
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit wx
: 528+ (Nightly build)
: All Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-03 15:17 PST by Kevin Watters
Modified: 2010-02-03 16:16 PST (History)
2 users (show)

See Also:


Attachments
fires a wx event in createWindow (4.78 KB, patch)
2010-02-03 15:17 PST, Kevin Watters
kevino: review+
kevino: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Watters 2010-02-03 15:17:45 PST
Created attachment 48069 [details]
fires a wx event in createWindow

ChomeClient's createWindow has a FIXME about firing an veto-able event.
Comment 1 WebKit Review Bot 2010-02-03 15:24:12 PST
Attachment 48069 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/wx/WebView.h:307:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Kevin Ollivier 2010-02-03 16:16:12 PST
Landed in r54309, thanks!