Bug 34540

Summary:

Establish a directory for third-party Python code

Product:

WebKit

Reporter:

Chris Jerdonek <cjerdonek>

Component:

Tools / Tests

Assignee:

Chris Jerdonek <cjerdonek>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, commit-queue, dpranke, eric, hamaji, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Chris Jerdonek

Reported 2010-02-03 12:36:25 PST

This report stems from the following webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2010-January/011394.html I'm thinking a location like one of the following might be good-- WebKitTools/Scripts/webkitpy/thirdparty, or WebKitTools/Scripts/webkitpy/external

Attachments
Proposed patch (23.81 KB, patch) 2010-02-20 08:58 PST, Chris Jerdonek	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Jerdonek

Comment 1 2010-02-20 08:58:52 PST

Adam Barth

Comment 2 2010-02-20 09:25:15 PST

Comment on attachment 49126 [details] Proposed patch I approve this product and/or service.

Chris Jerdonek

Comment 3 2010-02-20 09:43:23 PST

Comment on attachment 49126 [details] Proposed patch Clearing flags on attachment: 49126 Committed r55053: <http://trac.webkit.org/changeset/55053>

Chris Jerdonek

Comment 4 2010-02-20 09:43:28 PST

All reviewed patches have been landed. Closing bug.

Dirk Pranke

Comment 5 2010-02-22 10:43:58 PST

So should I move simplejson from WebKitTools/ to WebKitTools/Scripts/webkitpy/thirdparty, then?

Chris Jerdonek

Comment 6 2010-02-22 11:20:59 PST

(In reply to comment #5) > So should I move simplejson from WebKitTools/ to > WebKitTools/Scripts/webkitpy/thirdparty, then? Already done: https://bugs.webkit.org/show_bug.cgi?id=35196

Note You need to log in before you can comment on or make changes to this bug.