Bug 34518

Summary: [BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2010-02-03 03:01:19 PST
Add OwnPtrBrew to free BREW instances.
Attachments
Patch (6.55 KB, patch)
2010-02-03 03:03 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-02-03 03:03:38 PST
Created attachment 48006 [details] Patch
Eric Seidel (no email)
Comment 2 2010-02-03 12:59:51 PST
Comment on attachment 48006 [details] Patch Seems we should eventually share more code between things like this and GOwnPtr or RetainPtr. No need for each platform to copy/paste. If you'd like to file a bug about such code sharing, that'd be great. This looks fine to me.
WebKit Commit Bot
Comment 3 2010-02-03 13:17:28 PST
Comment on attachment 48006 [details] Patch Clearing flags on attachment: 48006 Committed r54294: <http://trac.webkit.org/changeset/54294>
WebKit Commit Bot
Comment 4 2010-02-03 13:17:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.