Bug 34516

Summary: [BREWMP] Port KURL::fileSystemPath
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Port KURL::fileSystemPath
none
Port KURL::fileSystemPath none

Description Kwang Yul Seo 2010-02-03 00:24:17 PST
Convert a file URL to a file path.
Comment 1 Kwang Yul Seo 2010-02-03 01:26:47 PST
Created attachment 48004 [details]
Port KURL::fileSystemPath
Comment 2 Eric Seidel (no email) 2010-02-03 16:20:26 PST
Comment on attachment 48004 [details]
Port KURL::fileSystemPath

Why is CString.h include needed?

Are you sure this is correct?  Does the brew port really never use root-relative file urls?
Comment 3 Kwang Yul Seo 2010-02-04 09:28:13 PST
(In reply to comment #2)
> (From update of attachment 48004 [details])
> Why is CString.h include needed?
> 
> Are you sure this is correct?  Does the brew port really never use
> root-relative file urls?

This is intentional. This follows the behavior of IWeb, BREW's HTTP engine which opens files in BREW's application-relative file namespace.
Comment 4 Kwang Yul Seo 2010-02-04 09:35:43 PST
Created attachment 48149 [details]
Port KURL::fileSystemPath

Add more comments to explain why we use application relative paths.
Comment 5 Eric Seidel (no email) 2010-02-08 15:49:33 PST
Comment on attachment 48149 [details]
Port KURL::fileSystemPath

I'm not sure how this will affect loading resources that WebCore depends on from disk.  Like cursor images or CSS files, but OK.
Comment 6 WebKit Commit Bot 2010-02-09 02:24:18 PST
Comment on attachment 48149 [details]
Port KURL::fileSystemPath

Clearing flags on attachment: 48149

Committed r54542: <http://trac.webkit.org/changeset/54542>
Comment 7 WebKit Commit Bot 2010-02-09 02:24:24 PST
All reviewed patches have been landed.  Closing bug.