Bug 34514

Summary:

[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

33564

Attachments:

Description	Flags
Patch	none

Description Kwang Yul Seo 2010-02-02 23:06:45 PST

WTF_PLATFORM_BREWMP_SIMULATOR is needed to make distinction between BREWMP and BREWMP simulator.

Comment 1 Kwang Yul Seo 2010-02-02 23:09:16 PST

Created attachment 47997 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-02-03 16:23:20 PST

Comment on attachment 47997 [details]
Patch

Do you compile the binary differently to run inside the simulator?  I guess so.

Comment 3 WebKit Commit Bot 2010-02-03 18:49:36 PST

Comment on attachment 47997 [details]
Patch

Clearing flags on attachment: 47997

Committed r54320: <http://trac.webkit.org/changeset/54320>

Comment 4 WebKit Commit Bot 2010-02-03 18:49:41 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Kwang Yul Seo 2010-02-03 18:53:10 PST

(In reply to comment #2)
> (From update of attachment 47997 [details])
> Do you compile the binary differently to run inside the simulator?  I guess so.

Yes. there is some simulator specific code. For example, IDebugger interface is not available for simulator, so I use OS(WINDOWS) code to retrieve the stack base address in simulator.