Summary: | 54113 causes crashes with -webkit-gradient and border-bottom | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hyatt, oliver, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
URL: | http://www.bing.com/reference/semhtml/Navagio | ||||||
Attachments: |
|
Description
James Robinson
2010-02-02 18:39:27 PST
Created attachment 47988 [details]
Patch
Comment on attachment 47988 [details]
Patch
Looks good.
Comment on attachment 47988 [details] Patch Clearing flags on attachment: 47988 Committed r54272: <http://trac.webkit.org/changeset/54272> All reviewed patches have been landed. Closing bug. The commit message is pretty borked: http://trac.webkit.org/changeset/54272 I think it's because the diff for WebCore/ChangeLog looks like this: -2010-02-02 Fumitoshi Ukai <ukai@chromium.org> +2010-02-02 James Robinson <jamesr@chromium.org> + Reviewed by NOBODY (OOPS!). + + Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash + https://bugs.webkit.org/show_bug.cgi?id=34510 + + * fast/gradients/crash-on-1px-border.html: Added. + +2010-02-02 Fumitoshi Ukai <ukai@chromium.org> where it should have been just: +2010-02-02 James Robinson <jamesr@chromium.org> + + Reviewed by NOBODY (OOPS!). + + Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash + https://bugs.webkit.org/show_bug.cgi?id=34510 + + * fast/gradients/crash-on-1px-border.html: Added. I guess git got a bit confused when generating the diff? My apologies, I meant LayoutTests/ChangeLog. The ChangeLog is now slightly out of order as well. |