Bug 34510

Summary: 54113 causes crashes with -webkit-gradient and border-bottom
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hyatt, oliver, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://www.bing.com/reference/semhtml/Navagio
Attachments:
Description Flags
Patch none

James Robinson
Reported 2010-02-02 18:39:27 PST
The following: <!DOCTYPE html> <div style="border-bottom:1px solid; background:-webkit-gradient(linear,0% 100%, 0% 100%, from(red),to(blue))"> </div> makes WebKit asplode after r54113. This structure is used on http://www.bing.com/reference/semhtml/Navagio (and probably other pages as well).
Attachments
Patch (2.87 KB, patch)
2010-02-02 19:42 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-02-02 19:42:28 PST
Created attachment 47988 [details] Patch
Dmitry Titov
Comment 2 2010-02-02 20:09:50 PST
Comment on attachment 47988 [details] Patch Looks good.
WebKit Commit Bot
Comment 3 2010-02-02 21:22:19 PST
Comment on attachment 47988 [details] Patch Clearing flags on attachment: 47988 Committed r54272: <http://trac.webkit.org/changeset/54272>
WebKit Commit Bot
Comment 4 2010-02-02 21:22:26 PST
All reviewed patches have been landed. Closing bug.
James Robinson
Comment 5 2010-02-02 21:25:36 PST
The commit message is pretty borked: http://trac.webkit.org/changeset/54272 I think it's because the diff for WebCore/ChangeLog looks like this: -2010-02-02 Fumitoshi Ukai <ukai@chromium.org> +2010-02-02 James Robinson <jamesr@chromium.org> + Reviewed by NOBODY (OOPS!). + + Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash + https://bugs.webkit.org/show_bug.cgi?id=34510 + + * fast/gradients/crash-on-1px-border.html: Added. + +2010-02-02 Fumitoshi Ukai <ukai@chromium.org> where it should have been just: +2010-02-02 James Robinson <jamesr@chromium.org> + + Reviewed by NOBODY (OOPS!). + + Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash + https://bugs.webkit.org/show_bug.cgi?id=34510 + + * fast/gradients/crash-on-1px-border.html: Added. I guess git got a bit confused when generating the diff?
James Robinson
Comment 6 2010-02-02 21:30:43 PST
My apologies, I meant LayoutTests/ChangeLog. The ChangeLog is now slightly out of order as well.
Note You need to log in before you can comment on or make changes to this bug.