Bug 34491

Summary: [Skia] GraphicsContext::beginTransparencyLayer doesn't retain the compositing mode
Product: WebKit Reporter: Garret Kelly <gdk>
Component: Layout and RenderingAssignee: Garret Kelly <gdk>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, dglazkov, eric, krit, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Initial patch none

Garret Kelly
Reported 2010-02-02 10:40:56 PST
When using the Skia graphics context, the beginTransparencyLayer call currently creates a new layer, but does not keep the current compositing mode for use when merging the created layer back onto the rest of the context. There's a test that exercises this functionality (fast/backgrounds/svg-ask-mask.html), but it's never passed in Chromium.
Attachments
Initial patch (3.83 KB, patch)
2010-02-02 10:42 PST, Garret Kelly 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Garret Kelly
Comment 1 2010-02-02 10:42:02 PST
Created attachment 47950 [details] Initial patch
Eric Seidel (no email)
Comment 2 2010-02-02 14:24:02 PST
It's still strange that we have a "PlatformContextSkia" abstraction layer. :) But glad this is fixed.
WebKit Commit Bot
Comment 3 2010-02-02 15:06:59 PST
Comment on attachment 47950 [details] Initial patch Clearing flags on attachment: 47950 Committed r54257: <http://trac.webkit.org/changeset/54257>
WebKit Commit Bot
Comment 4 2010-02-02 15:07:08 PST
All reviewed patches have been landed. Closing bug.
Dimitri Glazkov (Google)
Comment 5 2010-02-02 16:06:38 PST
Rolled out in http://trac.webkit.org/changeset/54262, because it broke basically all Win tests :)
Note You need to log in before you can comment on or make changes to this bug.