Summary: | [Chromium] Implement WebFrameImpl::pageNumberForElementById | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinichiro Hamaji <hamaji> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hayato, webkit.review.bot, yuzo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Shinichiro Hamaji
2010-02-02 04:33:58 PST
Created attachment 47921 [details]
Patch v1
Attachment 47921 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebFrameImpl.h:168: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/chromium/src/WebFrameImpl.h:169: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/chromium/src/WebFrameImpl.cpp:1522: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/chromium/src/WebFrameImpl.cpp:1523: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/chromium/src/WebFrameImpl.cpp:1532: page_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/chromium/public/WebFrame.h:490: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/chromium/public/WebFrame.h:491: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 7
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 47922 [details]
Patch v2
I've fixed the style issues. Thanks for the bot :) Comment on attachment 47922 [details]
Patch v2
sounds good!
Comment on attachment 47922 [details] Patch v2 Clearing flags on attachment: 47922 Committed r54270: <http://trac.webkit.org/changeset/54270> All reviewed patches have been landed. Closing bug. |