Bug 34471

Summary: [Chromium] Implement WebFrameImpl::pageNumberForElementById
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hayato, webkit.review.bot, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Shinichiro Hamaji
Reported 2010-02-02 04:33:58 PST
This is necessary to implement layoutTestController.pageNumberForElementById in test_shell. This API was added in http://trac.webkit.org/changeset/54205 Chromium bug: http://code.google.com/p/chromium/issues/detail?id=34219
Attachments
Patch v1 (3.02 KB, patch)
2010-02-02 04:35 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Patch v2 (3.00 KB, patch)
2010-02-02 04:48 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-02-02 04:35:09 PST
Created attachment 47921 [details] Patch v1
WebKit Review Bot
Comment 2 2010-02-02 04:40:24 PST
Attachment 47921 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebFrameImpl.h:168: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.h:169: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1522: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1523: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/src/WebFrameImpl.cpp:1532: page_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/public/WebFrame.h:490: page_width_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/public/WebFrame.h:491: page_height_in_pixels is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 7 If any of these errors are false positives, please file a bug against check-webkit-style.
Shinichiro Hamaji
Comment 3 2010-02-02 04:48:41 PST
Created attachment 47922 [details] Patch v2
Shinichiro Hamaji
Comment 4 2010-02-02 04:49:15 PST
I've fixed the style issues. Thanks for the bot :)
Dimitri Glazkov (Google)
Comment 5 2010-02-02 08:36:14 PST
Comment on attachment 47922 [details] Patch v2 sounds good!
Shinichiro Hamaji
Comment 6 2010-02-02 20:20:18 PST
Comment on attachment 47922 [details] Patch v2 Clearing flags on attachment: 47922 Committed r54270: <http://trac.webkit.org/changeset/54270>
Shinichiro Hamaji
Comment 7 2010-02-02 20:20:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.