Summary: | Web Inspector: Separate OS type from OS version (WebInspector.platform) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2010-02-02 03:15:43 PST
Created attachment 47931 [details]
[PATCH] Suggested solution
Comment on attachment 47931 [details] [PATCH] Suggested solution > +body.detached.platform-snowleopard #toolbar { I'd suggest to rename "platform-snowleopard" to "platform-mac-snowleopard" or "mac-snowleopard" > + return WebInspector.PlatformFlavor.WindowsVistaOrLater; We don't seem to be consistent. We have vista or later, but don't have snow leopard or later. Should Vista imply newer platforms? Created attachment 47936 [details]
[PATCH] Comments addressed
Comment on attachment 47936 [details] [PATCH] Comments addressed > + this._isMac = (WebInspector.platform === "mac"); No need for () here. "(...)" fixed. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InspectorBackendStub.js M WebCore/inspector/front-end/InspectorFrontendHostStub.js M WebCore/inspector/front-end/inspector.css M WebCore/inspector/front-end/inspector.js Committed r54240 |