Bug 34466

Summary: [Chromium] WebSecurityOrigin::createFromDatabaseIdentifier should not return a pointer
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch jorlow: review+, dumi: commit-queue-

Jeremy Orlow
Reported 2010-02-01 23:46:02 PST
WebSecurityOrigin::createFromDatabaseIdentifier should not return a pointer to a WebSecurityOrigin. It should simply be a WebSecurityOrigin.
Attachments
patch (3.27 KB, patch)
2010-04-16 15:46 PDT, Dumitru Daniliuc 		jorlow: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-02-11 12:11:53 PST
Thanks for taking that on Dumi! If you're super brave, there are probably other places like this that can be changed. If you're super duper brave, there are other places that can be changed like this IFF you add an equals operator to them (like WebStorageNamespace). If you don't want to do that stuff, it's fine though.
Dumitru Daniliuc
Comment 2 2010-04-16 15:46:26 PDT
Created attachment 53573 [details] patch Will land in Chromium as a 2-sided patch.
Jeremy Orlow
Comment 3 2010-04-16 15:58:42 PDT
Comment on attachment 53573 [details] patch Please follow the standard changeLog conventions.
Dumitru Daniliuc
Comment 4 2010-04-16 19:22:38 PDT
Landed as r57768 in WebKit and 44870 in Chromium.
Note You need to log in before you can comment on or make changes to this bug.