Bug 34460

Summary:

[Chromium] Add WebSecurityOrigin::createFromString factory

Product:

WebKit

Reporter:

Jeremy Orlow <jorlow>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	fishd: review+, fishd: commit-queue-

Description Jeremy Orlow 2010-02-01 18:17:09 PST

[Chromium] Add WebSecurityOrigin::createFromString factory

Comment 1 Jeremy Orlow 2010-02-01 18:17:49 PST

Created attachment 47894 [details]
Patch

Comment 2 Darin Fisher (:fishd, Google) 2010-02-01 22:55:06 PST

Comment on attachment 47894 [details]
Patch

> Index: WebKit/chromium/public/WebSecurityOrigin.h

>      WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& databaseIdentifier);
> +    WEBKIT_API static WebSecurityOrigin* createFromString(const WebString& origin);

There's no reason for either of these to return pointers.

WebSecurityOrigin is already like a smart pointer class.  Just return by value.

Comment 3 Jeremy Orlow 2010-02-01 23:43:30 PST

Created attachment 47908 [details]
Patch

Comment 4 Darin Fisher (:fishd, Google) 2010-02-02 00:09:19 PST

Comment on attachment 47908 [details]
Patch

> Index: WebKit/chromium/public/WebSecurityOrigin.h
> +    WEBKIT_API static WebSecurityOrigin createFromString(const WebString& origin);

nit: nix the origin parameter name.

otherwise, r=me

Comment 5 Jeremy Orlow 2010-02-02 00:52:38 PST

Committed r54214: <http://trac.webkit.org/changeset/54214>