Bug 34425

Summary: [Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
Product: WebKit Reporter: Yael <yael>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: kent.hansen, laszlo.gombos, markus
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1
none
Revert previous patch none

Yael
Reported 2010-02-01 06:39:28 PST
Sending data to a websocket connection should be controlled by the signals bytesWritten() and encryptedBytesWritten() instead of assuming that all the data was sent when send() is called.
Attachments
Patch v1 (4.13 KB, patch)
2010-02-02 12:05 PST, Yael 		no flags
DetailsFormatted DiffDiff
Revert previous patch (3.85 KB, patch)
2010-02-03 09:04 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Markus Goetz
Comment 1 2010-02-01 06:42:06 PST
I agree. And check for the result of bytesToWrite() and encryptedBytesToWrite() to keep the sum of both under a certain limit. See similar code in QHttpNetworkConnectionChannel::sendRequest().
Yael
Comment 2 2010-02-02 12:05:03 PST
Created attachment 47961 [details] Patch v1 Address the comments 14 and 15 from https://bugs.webkit.org/show_bug.cgi?id=34180.
Yael
Comment 3 2010-02-03 05:44:26 PST
Committed r54279: <http://trac.webkit.org/changeset/54279>
Yael
Comment 4 2010-02-03 09:04:18 PST
Created attachment 48043 [details] Revert previous patch The previous fix for this bug was a misunderstanding, and added un-necessary buffering. This patch is to revert the previous one, until a solution is found.
Yael
Comment 5 2010-02-03 14:01:43 PST
Reverted in r54298: <http://trac.webkit.org/changeset/54298>
Tor Arne Vestbø
Comment 6 2010-03-05 09:39:43 PST
Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component
Yael
Comment 7 2012-10-25 17:19:04 PDT
WebSockets implementation changed quite a lot since. I do not plan to make these changes.
Note You need to log in before you can comment on or make changes to this bug.