| Summary: | [Qt] Build without SSL support is broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Henry Haverinen <henry.haverinen> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hausmann, kenneth, laszlo.gombos, yael | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Attachments: |
|
||||||
|
Description
Henry Haverinen
2010-02-01 04:45:03 PST
Sorry, I forgot about that. Henry has a patch coming up :) Our product manager is programming now? :-) rocks! Created attachment 47839 [details]
build fix
Comment on attachment 47839 [details] build fix You need to put the patch up for review, I have done so now. > + } else > m_socket = new QTcpSocket(this); > + > + if (!m_socket) > + return; Why did you add this early return. The new is supposed to return something valid, unless we are out of memory. Committed r54134: <http://trac.webkit.org/changeset/54134> (In reply to comment #5) > (From update of attachment 47839 [details]) > You need to put the patch up for review, I have done so now. > > + } else > > m_socket = new QTcpSocket(this); > > + > > + if (!m_socket) > > + return; > Why did you add this early return. The new is supposed to return something > valid, unless we are out of memory. The return is not related to the new just above it, but to an #ifndef'd new above it. Without SSL support, there's no way to create a valid socket for this case. (In reply to comment #7) > The return is not related to the new just above it, but to an #ifndef'd new > above it. Without SSL support, there's no way to create a valid socket for this > case. OK, great! :-) |