Bug 34416 – [Qt] Build without SSL support is broken

• Component: New Bugs
• Status: RESOLVED FIXED

[Henry Haverinen]

If Qt is configured without SSL support, then the build breaks in SocketStreamHandler.

[Yael]

Sorry, I forgot about that.

[Simon Hausmann]

Henry has a patch coming up :)

[Kenneth Rohde Christiansen]

Our product manager is programming now? :-) rocks!

[Henry Haverinen]

Created attachment 47839 [details]
build fix

[Kenneth Rohde Christiansen]

Comment on attachment 47839 [details]
build fix

You need to put the patch up for review, I have done so now.


> +    } else
>          m_socket = new QTcpSocket(this);
> +
> +    if (!m_socket)
> +        return;

Why did you add this early return. The new is supposed to return something valid, unless we are out of memory.

[Simon Hausmann]

Committed r54134: <http://trac.webkit.org/changeset/54134>

[Henry Haverinen]

(In reply to comment #5)
> (From update of attachment 47839 [details])
> You need to put the patch up for review, I have done so now.
> > +    } else
> >          m_socket = new QTcpSocket(this);
> > +
> > +    if (!m_socket)
> > +        return;
> Why did you add this early return. The new is supposed to return something
> valid, unless we are out of memory.

The return is not related to the new just above it, but to an #ifndef'd new above it. Without SSL support, there's no way to create a valid socket for this case.

[Kenneth Rohde Christiansen]

(In reply to comment #7)
> The return is not related to the new just above it, but to an #ifndef'd new
> above it. Without SSL support, there's no way to create a valid socket for this
> case.

OK, great! :-)