|Summary:||[Qt] Build without SSL support is broken|
|Product:||WebKit||Reporter:||Henry Haverinen <henry.haverinen>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||hausmann, kenneth, laszlo.gombos, yael|
|Version:||528+ (Nightly build)|
Description Henry Haverinen 2010-02-01 04:45:03 PST
If Qt is configured without SSL support, then the build breaks in SocketStreamHandler.
Comment 1 Yael 2010-02-01 06:42:50 PST
Sorry, I forgot about that.
Comment 2 Simon Hausmann 2010-02-01 06:48:31 PST
Henry has a patch coming up :)
Comment 3 Kenneth Rohde Christiansen 2010-02-01 06:52:57 PST
Our product manager is programming now? :-) rocks!
Comment 5 Kenneth Rohde Christiansen 2010-02-01 07:02:18 PST
Comment on attachment 47839 [details] build fix You need to put the patch up for review, I have done so now. > + } else > m_socket = new QTcpSocket(this); > + > + if (!m_socket) > + return; Why did you add this early return. The new is supposed to return something valid, unless we are out of memory.
Comment 6 Simon Hausmann 2010-02-01 07:04:02 PST
Committed r54134: <http://trac.webkit.org/changeset/54134>
Comment 7 Henry Haverinen 2010-02-01 07:07:42 PST
(In reply to comment #5) > (From update of attachment 47839 [details]) > You need to put the patch up for review, I have done so now. > > + } else > > m_socket = new QTcpSocket(this); > > + > > + if (!m_socket) > > + return; > Why did you add this early return. The new is supposed to return something > valid, unless we are out of memory. The return is not related to the new just above it, but to an #ifndef'd new above it. Without SSL support, there's no way to create a valid socket for this case.